Forums Feature Requests Thread

[Enhancement] Admin plane: Orphaned template admin/users/edit.php — edit() now redirects, nothing renders this template

Patrick Bass · Jun 6 · 14 · 1 Locked
[Normal Priority] [Feature Enhancement] [Deployed to Production]
🚀 OP Jun 6, 2026 7:37pm

Area: Admin plane (audit p12) · Surface: templates/admin/users/edit.php · Dimension: dead-code · Severity: minor

templates/admin/users/edit.php is a self-described dormant standalone edit page, kept "in case the redirect is ever lifted." It has zero inbound references today. The actual edit surface is the tabbed show.php page. This is intentionally-retained dead code, not a bug — a removal candidate.

Evidence

AdminUserController::edit() (platform/src/Controllers/AdminUserController.php:149-152) is just `$this->redirect('/admin/users/' . (int) $id . '?tab=profile');` — it no longer renders this template. Grep proof that nothing renders/includes admin/users/edit:
$ grep -rn 'admin/users/edit\|users/edit.php' src/ templates/  →
  templates/admin/users/edit.php:3: docblock only
No render() and no include() of this template exists. The template's own docblock confirms it: "In the current routing, AdminUserController::edit redirects to /admin/users/{id}?tab=profile, so this template is dormant."  (The shared partial it includes, _tab-profile.php, IS live — included by templates/admin/users/show.php:186.)

Suggested fix. Either delete templates/admin/users/edit.php (the _tab-profile.php partial covers the form body and is already used by show.php), or, if the deep-link/reset-flow use case is real, wire a route to it. Leaving it dormant is fine but it is dead today.

Filed by the automated tenant-app audit and adversarially evidence-verified. Status: verified. Open — not yet actioned.


Patrick Bass
@mobieus

🚀 Jun 7, 2026 10:24am

Resolved and deployed. Commit ca230723ea.

templates/admin/users/edit.php deleted — AdminUserController::edit() redirects to show?tab=profile; this template had zero inbound render references.

Closed as: shipped.


Patrick Bass
@mobieus

Log in or register to reply to this thread.