Forums Bug Reports Thread

Queue diff rows use hardcoded rgba green/red tints instead of semantic color-mix (theme drift)

Patrick Bass · Jun 6 · 16 · 1 Locked
[Minor] [Normal Priority] [Bug Fixed] [Always Reproduces]
🚀 OP Jun 6, 2026 6:11pm

Area: mobieusKnow (audit p6) · Surface: mobieusKnow review queue diff · Dimension: law-3-contrast · Severity: minor

These add/del row tints are hardcoded sRGB greens/reds rather than the semantic tokens. The fixed #22c55e green doesn't match the dark-theme success token (#00FF88) or the light-theme token (#16a34a), so the diff highlight color is inconsistent with the rest of the surface across themes. Contrast of the overlaid var(--color-text-primary) body text still holds because the tint is only 8% alpha, so this is a consistency/theme-token issue rather than an unreadable failure — hence minor. The fix is already demonstrated one file over in revision.php.

Evidence

queue.php:124 .wk-q-diff-row.op-add { background: rgba(34,197,94,0.08); …} and queue.php:126 .wk-q-diff-row.op-del { background: rgba(239,68,68,0.08); …}. The sibling revision.php:91-93 does the same job correctly with color-mix(in srgb, var(--color-success) 8%, transparent) / var(--color-danger). The editor trust banners also hardcode rgba(34,197,94,...) / rgba(255,179,71,...) at editor.php:45 and :50.

Suggested fix. Replace the hardcoded rgba() backgrounds with color-mix(in srgb, var(--color-success) 8%, transparent) and color-mix(in srgb, var(--color-danger) 8%, transparent), matching revision.php. Do the same for the editor trust banners (use color-mix on --color-success / --color-warning).

Filed by the automated tenant-app audit and adversarially evidence-verified. Status: verified. Open — not yet actioned.


Patrick Bass
@mobieus

🚀 Jun 7, 2026 5:38am

Resolved — fixed and deployed. Commit 89b2334003a7, shipped dev-first then to all tenants on 2026-06-06.

Replaced hardcoded rgba(34,197,94,0.08) and rgba(239,68,68,0.08) diff-row backgrounds with color-mix(in srgb, var(--color-success)/--color-danger 8%, transparent), matching revision.php. The 'editor trust banners' part of the note refers to a different template (the knowledge editor), not queue.php; no trust banners exist in this file.

Status: fixed. Thread closed and locked.


Patrick Bass
@mobieus

Log in or register to reply to this thread.