Forum settings paid-access alerts use hardcoded dark text with no dark-theme flip (dark-on-dark)

Area: Forums (audit p2) · Surface: GET /forums/{slug}/settings (ForumController, templates/forums/settings.php) · Dimension: Law 3 — contrast in every theme · Severity: major

On the forum Settings/Branding page, the 'Paid access is active' success alert and the 'Pending platform approval' warning alert hardcode dark green/amber text. There is no dark-theme override for .fs-alert, so in dark mode the dark text renders on a dark-tinted background and is barely legible. Violates Law 3 (semantic tokens / contrast in every theme).

Evidence

templates/forums/settings.php:429-430:
.fs-alert--success{background:rgba(34,197,94,.08);border:1px solid rgba(34,197,94,.24);color:#0f6b3b}
.fs-alert--warn{background:rgba(245,158,11,.08);border:1px solid rgba(245,158,11,.24);color:#92580f}
The text colors #0f6b3b (dark green) and #92580f (dark amber) are hardcoded. The dark-theme override block at settings.php:448-451 only covers .fs-card/.fs-tool/.fs-tabs — NOT .fs-alert. grep confirms .fs-alert is defined nowhere else (no global override in any css). In [data-theme] (dark), the 8%-opacity tint sits over a dark surface (--color-bg-card resolves to #0E1228 area) so the alert background reads dark, and the dark text stays dark = dark-on-dark. Rendered at settings.php:153 (.fs-alert--success) and :158 (.fs-alert--warn).

Suggested fix. Replace the hardcoded text colors with semantic tokens (color:var(--color-success) / var(--color-warning)) or add a body[data-theme] .fs-alert--success/--warn override that lightens the text in dark mode, matching the existing .fs-card/.fs-tool dark overrides.

Filed by the automated tenant-app audit and adversarially evidence-verified. Status: verified. Open — not yet actioned.