Forums Bug Reports Thread

Forum 'Best Of' page is a nav orphan — reachable only by typing the URL

Patrick Bass · Jun 6 · 8 · 1 Locked
[Major] [High Priority] [Bug Fixed] [Always Reproduces]
🚀 OP Jun 6, 2026 5:27pm

Area: Forums (audit p2) · Surface: GET /forums/{slug}/best-of (ForumController@bestOf, templates/forums/best-of.php) · Dimension: Law 2 — no nav orphans · Severity: major

The 'Best Of' forum page has a registered route and a fully built template, but no template anywhere links to it. Users can only reach it by manually typing /forums/<slug>/best-of. This is a Law 2 nav orphan.

Evidence

Route is registered and real: routes.php:374 $router->get('/forums/{slug}/best-of', 'ForumController@bestOf'); controller at ForumController.php:4402 renders a real page (templates/forums/best-of.php, 78 lines, table of best posts). But grep for any link across all templates finds none: `grep -rnE 'best-of|bestOf' templates/` returns only best-of.php itself plus an unrelated marketplace-rules.php mention. The forum action menus do NOT link it — _action-bar.php:62-80 lists Settings/Members/Mods/Mod Log/AutoMod/Edit Description/Escalate/Delete; show.php:351-378 dropdown lists About/Settings/Members/Moderators/Delete; neither references best-of.

Suggested fix. Add a 'Best Of' link to the forum action bar (templates/forums/_action-bar.php) and/or the forum sub-nav/dropdown in show.php (around the About/sort-tabs area), using href="/forums/<?= $e($forum['slug']) ?>/best-of".

Filed by the automated tenant-app audit and adversarially evidence-verified. Status: verified. Open — not yet actioned.


Patrick Bass
@mobieus

🚀 Jun 7, 2026 4:59am

Resolved — fixed and deployed. Commit faa14fc59739, shipped dev-first then to all tenants on 2026-06-06.

Added a 'Best Of' link (href=/forums/<slug>/best-of) to _action-bar.php. The route and ForumController@bestOf existed but were unreachable from any UI. Placed it in its own action-bar row outside the $currentUser guard since the controller allows anonymous viewers, styled as btn btn--outline btn--sm to match existing action-bar buttons, slug escaped via $e().

Status: fixed. Thread closed and locked.


Patrick Bass
@mobieus

Log in or register to reply to this thread.